Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity in parameter attribute names #83

Closed
BDonnot opened this issue May 14, 2020 · 1 comment
Closed

Improve clarity in parameter attribute names #83

BDonnot opened this issue May 14, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@BDonnot
Copy link
Collaborator

BDonnot commented May 14, 2020

Some attributes names in the Parameters are obscure, for example NB_TIMESTEP_POWERFLOW_ALLOWED which should be NB_TIMESTEP_OVERFLOW_ALLOWED.

We can also improve names of the NB_TIMESTEP_TOPOLOGY_REMODIF and NB_TIMESTEP_LINE_STATUS_REMODIF to match the "cooldown" terminology adopted in observation for example.

To this regard, observation attribute time_before_cooldown_line and time_before_cooldown_sub are not that clear.

Also NB_TIMESTEP_RECONNECTION means something like "number of time step i have to wait if i disconnect a powerline that has been deconnected because of an overflow". The name is not clear.

@BDonnot BDonnot added the enhancement New feature or request label May 14, 2020
BDonnot referenced this issue in BDonnot/Grid2Op May 15, 2020
@BDonnot
Copy link
Collaborator Author

BDonnot commented May 19, 2020

This has been improved in 0.9.0

@BDonnot BDonnot closed this as completed May 19, 2020
BDonnot added a commit that referenced this issue Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant