Skip to content

Commit

Permalink
up version to fix last reference to rhdf5 pacakge
Browse files Browse the repository at this point in the history
  • Loading branch information
berthetclement committed Jun 27, 2024
1 parent 37d4acd commit 87ba32d
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 11 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: antaresViz
Type: Package
Title: Antares Visualizations
Version: 0.18.1
Version: 0.18.2
Authors@R: c(
person("Tatiana", "Vargas", email = "tatiana.vargas@rte-france.com", role = c("aut", "cre")),
person("Jalal-Edine", "Zawam", role = "aut"),
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Copyright 2016 RTE Reseau de transport d'electricite

# antaresViz 0.18.2
* fix cran issue on test not skip well

# antaresViz 0.18.1
* delete package dependecies `rhdf5`

Expand Down
3 changes: 3 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,6 @@ new version to fix pb with dependencies `AntaresRead` :

We have to fix dependencies with package `rhdf5` on this package before to push `antaresRead` 2.7.1

## v0.18.2
Cran check in ERROR cause test skip not skip

20 changes: 10 additions & 10 deletions tests/testthat/test-plotXY.R
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
context("prodStack no interactive")

test_that("prodStack, no interactive", {
skip_if_not_installed("hexbin")
if(.requireRhdf5_Antares(stopP = FALSE)){
dta <- readAntares(areas = "all", showProgress = FALSE)
g <- plotXY(dta, "NODU", "LOAD", precision = 50, sizeOnCount = FALSE)
expect_true("htmlwidget" %in% class(g))
}
})
# context("prodStack no interactive")
#
# test_that("prodStack, no interactive", {
# skip_if_not_installed("hexbin")
# if(.requireRhdf5_Antares(stopP = FALSE)){
# dta <- readAntares(areas = "all", showProgress = FALSE)
# g <- plotXY(dta, "NODU", "LOAD", precision = 50, sizeOnCount = FALSE)
# expect_true("htmlwidget" %in% class(g))
# }
# })

0 comments on commit 87ba32d

Please sign in to comment.