Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm compatibility with WordPress 6.6 #468

Open
8 tasks
joelabreo227 opened this issue Jul 15, 2024 · 9 comments · Fixed by #478 or #479
Open
8 tasks

Confirm compatibility with WordPress 6.6 #468

joelabreo227 opened this issue Jul 15, 2024 · 9 comments · Fixed by #478 or #479
Assignees

Comments

@joelabreo227
Copy link

joelabreo227 commented Jul 15, 2024

Summary

Confirm compatibility with WordPress 6.6.

Team

Primary Assignee: @mchirag2002
PR reviewer: @SH4LIN
QA: @maharrshi

References

Acceptance Criteria

  • As a WordPress engineer, I can use Elementary to scaffold a brand new project with WordPress 6.6
  • New features work as expected
  • Deprecations are gracefully handled

Additional Tasks

Preview Give feedback
@mchirag2002
Copy link
Contributor

Things Tested:

  • Theme installation functionality
  • Development commands like npm commands.

Issues encountered and fixes for them:

  • Found a deprecated node parser

    image

    Fix: Update the node module.

  • Found several PHPCS issues in multiple files related to 'Short array syntax usage'

    image

    Also found the following issues when WordPress-VIP-Go standard was used to check

    image

    Fix: Update the syntax and fix all the phpcs issues with WordPress standard and raise a PR to main.

New features that can be used in the project:

cc: @joelabreo227

@mchirag2002
Copy link
Contributor

New features that can be used in the project: (Contd.)

  • We can also leverage the Section Styles feature integrated with the default font size and typography feature in theme.json to provide the end user a lot of preset styles for their new custom themes.

@RahiDroid
Copy link
Member

@mchirag2002 The flagged issue look fine to be fixed. For below,

Found several PHPCS issues in multiple files related to 'Short array syntax usage'

We at rtCamp prefer to use short-array syntax. So please update the phpcs.xml file to ignore that sniff.

This was referenced Jul 18, 2024
@maharrshi
Copy link

Installation Setup:

Method 1: Does not work
Steps Followed:
1: setup local site
2: from the themes directory ran the command: composer create-project rtcamp/elementary [folder_name]
3: while going through the themes set up following error occurs:
image
The log file for the same :
2024-07-19T09_49_42_659Z-debug-0.log

Method 2: Works fine
cc: @mchirag2002

@maharrshi
Copy link

Theme check produces errors
image

@SH4LIN
Copy link
Contributor

SH4LIN commented Jul 19, 2024

Installation Setup:

Method 1: Does not work Steps Followed: 1: setup local site 2: from the themes directory ran the command: composer create-project rtcamp/elementary [folder_name] 3: while going through the themes set up following error occurs: image The log file for the same : 2024-07-19T09_49_42_659Z-debug-0.log

Method 2: Works fine cc: @mchirag2002

I think this is happening because the theme elementary inside our composer package is not updated. What you are facing is an issue that was fixed a long time ago. I'll create task to update the composer theme

@SH4LIN
Copy link
Contributor

SH4LIN commented Jul 21, 2024

Confirm maximum PHP compatibility.

Tested the theme in PHP version 8.3 and everything works perfectly.

@maharrshi
Copy link

image
image
Found these css errors while checking for the site on https://validator.w3.org/
cc: @mchirag2002 @SH4LIN

@maharrshi
Copy link

QA Completed
Site Tested: Local Site
QA Checklist Performed:

  • Installation using two methods as per readme
  • Theme check - unit testing for the theme
  • Error logs and console errors checks
  • CSS Validation
  • Performance check
  • Cross Browser Tested(Chrome, Safari, Edge)
  • Responsive Testing
    cc: @joelabreo227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants