Merge pull request #725 from JohnnyKei/fix/query_param_encoding

fix: encode query params when use schema type

CHANGELOG.md

@@ -15,6 +15,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 ### Fixed
 
 - Allow vendor-specific MIME types for JSON payloads (https://github.com/rswag/rswag/pull/769)
+- Fix escaping of schema in path parameters for openapi spec >= 3.0.0 (https://github.com/rswag/rswag/pull/725)
 
 ## [2.14.0] - 2024-08-13
 

rswag-specs/lib/rswag/specs/request_factory.rb

@@ -174,7 +174,7 @@ def build_query_string_part(param, value, swagger_doc)
               return "#{escaped_name}=" + value.to_a.flatten.map{|v| CGI.escape(v.to_s) }.join(separator)
             end
           else
-            return "#{name}=#{value}"
+            return "#{escaped_name}=#{CGI.escape(value.to_s)}"
           end
         end
 

rswag-specs/spec/rswag/specs/request_factory_spec.rb

@@ -169,6 +169,20 @@ module Specs
               expect(request[:path]).to eq('/blogs?date_time=2001-02-03T04%3A05%3A06-07%3A00')
             end
           end
+
+          context 'openapi spec >= 3.0.0' do
+            let(:openapi_spec) { { swagger: '3.0' } }
+            before do
+              allow(example).to receive(:date_time).and_return(date_time)
+            end
+
+            it 'formats the datetime properly when type is defined in schema' do
+              metadata[:operation][:parameters] = [
+                { name: 'date_time', in: :query, schema: { type: :string }, format: :datetime, }
+              ]
+              expect(request[:path]).to eq('/blogs?date_time=2001-02-03T04%3A05%3A06-07%3A00')
+            end
+          end
         end
 
         context "'query' parameters of type 'object'" do