support virtualized list for TreePicker and CheckTreePicker #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonguo
reviewed
Jan 24, 2019
src/CheckTreePicker/utils.js
Outdated
| * @param {*} expandItemValues | ||
| * @param {*} parentKeys | ||
| */ | ||
| export function shouldShowNodeByExpanded(expandItemValues: any[] = [], parentKeys: any[] = []) { |
There was a problem hiding this comment.
shouldShowNodeByExpanded 与 TreePicker 中的方法重复，可以通用放到全局的 utils 目录下。
simonguo
reviewed
Jan 24, 2019
| @@ -60,6 +79,7 @@ type Props = { | |||
| placement?: Placement, | |||
| searchable?: boolean, | |||
| appearance: 'default' | 'subtle', | |||
| virtualized: boolean, | |||
There was a problem hiding this comment.
在 typescript 定义中添加 virtualized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.