Fix issues rendering shiny runtime Rmds from rmdshot()
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
approved these changes
Jul 17, 2023
|
Thanks for the fix! |
wch
reviewed
Jul 17, 2023
| @@ -1,3 +1,7 @@ | |||
| # webshot2 (development version) | |||
|
|
|||
| * Fixed `rmdshot()` when used to screenshot an R Markdown document with `runtime: shiny` or `runtime: shinyrmd` (#52). | |||
There was a problem hiding this comment.
I just merged but then realized that this doesn't quite have the same format as other NEWS items. It should be
* Fixed #52: `rmdshot()` did not work when used to screenshot an R Markdown document with `runtime: shiny` or `runtime: shinyrmd`. (#53)
I'll fix on main.
There was a problem hiding this comment.
🤔 but there aren't any other NEWS items in this repo.
Is this style guidance written down somewhere? It would be helpful, both internally and externally if it were. And along those lines, while I can live with us deviating from the tidyverse style, it'd be easier for external collaborators and new contributors if we adopted the tidyverse style guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52:
rmd_argstormarkdown::run(render_args =)ptowait_until_server_exists(), without which an error is thrown.