-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
17 changed files
with
190 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,3 +5,6 @@ | |
^_pkgdown\.yml$ | ||
^docs$ | ||
^pkgdown$ | ||
^cran-comments\.md$ | ||
^CRAN-SUBMISSION$ | ||
^man-roxygen$ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
Version: 0.1.0 | ||
Date: 2022-05-12 17:03:24 UTC | ||
SHA: 69cbecdbe9d1ea72fcca2aa8af95f79d5fec9bb5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# webshot2 0.1.0 | ||
|
||
* Added a `NEWS.md` file to track changes to the package. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
## Comments | ||
|
||
#### 2022-05-13 | ||
|
||
Updates: | ||
* I have added `\value` docs for all five methods. | ||
* I have removed the commented code in the example of `rmdshot.Rd` | ||
|
||
Thank you, | ||
Winston | ||
|
||
|
||
#### 2022-05-13 | ||
|
||
Thanks, | ||
|
||
Please add \value to .Rd files regarding exported methods and explain | ||
the functions results in the documentation. Please write about the | ||
structure of the output (class) and also what the output means. (If a | ||
function does not return a value, please document that too, e.g. | ||
\value{No return value, called for side effects} or similar) | ||
Missing Rd-tags: | ||
appshot.Rd: \value | ||
resize.Rd: \value | ||
rmdshot.Rd: \value | ||
shrink.Rd: \value | ||
webshot.Rd: \value | ||
|
||
Some code lines in examples are commented out in rmdshot.Rd | ||
Please never do that. Ideally find toy examples that can be regularly | ||
executed and checked. Lengthy examples (> 5 sec), can be wrapped in | ||
\donttest{}. | ||
If you use external software for examples, please wrap them in | ||
\dontrun{} instead. | ||
|
||
Please fix and resubmit. | ||
|
||
Best, | ||
Victoria Wimmer | ||
|
||
#### 2022-05-12 | ||
|
||
Releasing a new package `{webshot2}`. | ||
|
||
The invalid url to https://www.r-pkg.org/pkg/webshot2 should work once the package is on CRAN. | ||
|
||
Please let me know if there is any more information I can provide. | ||
|
||
Thank you, | ||
Winston | ||
|
||
|
||
## Test environments | ||
|
||
* local macOS, R 4.1.3 | ||
* GitHub Actions | ||
* macOS | ||
* 4.2 | ||
* windows | ||
* 4.2 | ||
* ubuntu18 | ||
* devel, 4.2, 4.1, 4.0, 3.6, 3.5 | ||
* devtools:: | ||
* check_win_devel() | ||
* check_win_release() | ||
* check_win_oldrelease() | ||
|
||
## R CMD check results | ||
|
||
0 errors ✔ | 0 warnings ✔ | 1 note | ||
|
||
N checking CRAN incoming feasibility | ||
Maintainer: ‘Winston Chang <winston@rstudio.com>’ | ||
|
||
New submission | ||
|
||
Found the following (possibly) invalid URLs: | ||
URL: https://www.r-pkg.org/pkg/webshot2 | ||
From: README.md | ||
Status: 500 | ||
Message: Internal Server Error |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
#' @return Invisibly returns the normalized path to all screenshots taken. The | ||
#' character vector will have a class of `"webshot"`. |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.