Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: update templates to render out of the box #229

Merged
merged 2 commits into from
Dec 17, 2024
Merged

maint: update templates to render out of the box #229

merged 2 commits into from
Dec 17, 2024

Conversation

isabelizimm
Copy link
Contributor

closes #220

  • update links from now-deactivated Colorado server
  • move from pydantic v1 -> v2 calling of prototypes

isabelizimm
isabelizimm commented Dec 17, 2024
View reviewed changes
vetiver/templates/model_card.qmd
@@ -134,7 +137,7 @@ dmp
## Visualize model performance

```{python}
performance = px.scatter(sacramento, x="price", y = "preds", facet_row="type", trendline="ols")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing trendline to avoid forcing a statsmodels install, which is not a required package in vetiver

@isabelizimm isabelizimm merged commit c6b33de into main Dec 17, 2024
13 checks passed
@isabelizimm isabelizimm deleted the templates branch December 17, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model card template errors on render
1 participant
@isabelizimm