Fix #103 #104

rossellhayes · 2021-12-03T22:09:39Z

library(tblcheck)

.result   <- c(3, 4, 3)
.solution <- c(3, 4, 3, 4, 3)
vec_grade_length()
#> <gradethis_graded: [Incorrect]
#>   Your result should contain 5 values, but it has 3 values.
#> >

^{Created on 2021-12-03 by the reprex package (v2.0.1)}

Closes #103.

gadenbuie

LGTM! One small comment that you can take or leave

R/check_dimensions.R

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

Fix #103

7deddbf

rossellhayes added the bug Something isn't working label Dec 3, 2021

rossellhayes requested a review from gadenbuie December 3, 2021 22:09

rossellhayes self-assigned this Dec 3, 2021

gadenbuie approved these changes Dec 7, 2021

View reviewed changes

R/check_dimensions.R Outdated Show resolved Hide resolved

Remove early return to focus on change in problem$value_message

b352e73

Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>

rossellhayes merged commit ca072b1 into main Dec 7, 2021

rossellhayes deleted the fix-length-message branch December 7, 2021 17:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #103 #104

Fix #103 #104

rossellhayes commented Dec 3, 2021

gadenbuie left a comment

Fix #103 #104

Fix #103 #104

Conversation

rossellhayes commented Dec 3, 2021

gadenbuie left a comment

Choose a reason for hiding this comment