Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove {ellipsis} in favour of {rlang} #382

Merged
merged 4 commits into from
Apr 10, 2024
Merged

chore: Remove {ellipsis} in favour of {rlang} #382

merged 4 commits into from
Apr 10, 2024

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Apr 9, 2024

since ellipsis is replaced by rlang

@schloerke schloerke self-requested a review April 10, 2024 19:41
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a news entry, please?

DESCRIPTION Show resolved Hide resolved
@schloerke schloerke changed the title Remove ellipsis in favour of rlang chore: Remove {ellipsis} in favour of {rlang} Apr 10, 2024
@schloerke schloerke enabled auto-merge (squash) April 10, 2024 19:58
@schloerke
Copy link
Collaborator

Thank you!

CI Failures are unrelated to PR. PR is set for merging

@schloerke schloerke merged commit 436535d into rstudio:main Apr 10, 2024
5 of 17 checks passed
@olivroy olivroy deleted the ellipsis branch April 10, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants