Updated timeout values; Add support for $new(timeout=); Drop CI support for $new(load_timeout=); Add option and envvar support for $new(load_timeout=, timeout=)

[schloerke]

Fixes #213

• Tests
• News entry

[schloerke]

I'm thinking we should scrap the timeout methods entirely and just make the startup time 10s and all other timeouts 4s.

The timeout defaults could be missing_arg() or getOption("shinytest2.timeout", 4 * 1000). If it is a missing_arg(), we could have it read the internal timeout value from AppDriver$new(timeout = XYZ). If not a missing_arg(), then there's no need for AppDriver$new(timeout = XYZ).

The AppDriver$new(load_timeout=) could default to getOption("shinytest2.load_timeout", 10 * 1000) instead of NULL to be explicit.

---

Then there's no confusion about CI... which value has been set... why the method name is about timeout, but arguments are about step or stepsize which doesn't immediately mean anything about timeouts.

Everything is just straight forward. Here's the timeout value.

[schloerke]

Original PR from {shinytest}: https://github.com/rstudio/shinytest/pull/335/files

I think the only motivation was for GHA to be able to load the shiny apps without having to set any parameters. I think I was wrong to take that motivation for all timeout values within the package

[schloerke]

Moving forward with something like

# Definition could be
app1 <- AppDriver$new(
  load_timeout = getOption("shinytest2.load_timeout", 10 * 1000),
  timeout = getOption("shinytest2.timeout", 4 * 1000)
)
# Definition could be
app1$run_js(timeout = missing_arg())
# Where
timeout <- rlang::maybe_missing(timeout, private$timeout)

---

• Implement new approach
• Drop new methods add in this PR

[gadenbuie]

I think the only motivation was for GHA to be able to load the shiny apps without having to set any parameters.

For this motivation it might be worth adding an envvar lookup to the default value resolution, e.g. options → envvar → default value, since it's a lot easier to set the envvar in CI.

[gadenbuie]

Looks great! ⏲️ ⏳