AppDriver$wait_for_js() does not quote script input

[fproske]

The eval() call in the chromote_wait_for_condition function is essentially a NOP instruction as the condition_js script is not quoted:

shinytest2/R/chromote-methods.R

Line 105 in 61d51d9

return eval(", condition_js, ");

This leads to e.g. the input script 'test'==='test'; throwing a Javascript error: SyntaxError: Unexpected token ';'. Expected ')' to end an argument list. as the code to be executed looks like this: eval('test'==='test';) which is obviously invalid syntax.
To fix this, the condition_js needs to be quoted properly.

[yogat3ch]

Hi @schloerke,
opening this back up because I found a bug where an object of class glue, character passed as the condition_js argument to wait_for_js will produce an error.

app$wait_for_js(UU::glue_js("$('#*{ns('highlighted')}* table.dataTable > tbody > tr').length == 1;"))

produces an error:

I think this can be resolved by simply wrapping condition_js on the line mentioned above in as.character as the following works:

app$wait_for_js(as.character(UU::glue_js("$('#*{ns('highlighted')}* table.dataTable > tbody > tr').length == 1;")))

[schloerke]

{glue} is so weird. lol.

Thank you for the fix!

[schloerke]

@yogat3ch Hopefully fixed in #288

[yogat3ch]

@schloerke Very much appreciated!!! 🙏