Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow bindInputs() to no-op when attempting to bind currently bound inputs #3946

Merged
merged 22 commits into from
Nov 30, 2023
Merged

fix: Allow bindInputs() to no-op when attempting to bind currently bound inputs #3946

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
657be0a
fix: Do not re-bind previously bound inputs
gadenbuie Nov 29, 2023
3aa2f6c
refactor: Add binding to the registry after binding happens
gadenbuie Nov 29, 2023
0c03210
fix: Spelling of `bindingsRegistry`
gadenbuie Nov 29, 2023
7969054
chore: yarn build
gadenbuie Nov 29, 2023
554bac5
`yarn build` (GitHub Actions)
gadenbuie Nov 29, 2023
1b9ceab
fix: spelling
gadenbuie Nov 29, 2023
9d1f5c7
feat: isRegistered can check if bound to input or output
gadenbuie Nov 29, 2023
6eba4cf
fix: Do not throw for shared input/output IDs
gadenbuie Nov 29, 2023
f1a072e
fix: check element directly to know whether it a bound input
gadenbuie Nov 29, 2023
3e00632
chore: yarn build
gadenbuie Nov 29, 2023
26e5109
fix: test `.shiny-bound-input` instead of data prop
gadenbuie Nov 29, 2023
b67b062
refactor: Remove `bindingsRegistry.isRegistered()` method
gadenbuie Nov 29, 2023
616bda0
refactor: Use a map for duplicateIds again
gadenbuie Nov 29, 2023
b124d1b
refactor: Add `BindingTypes` type and use `bindingType` everywhere
gadenbuie Nov 29, 2023
1c0c4c3
Merged origin/main into fix/error-console-insert-ui
gadenbuie Nov 29, 2023
76abdca
refactor: More concise duplicateIds typing
gadenbuie Nov 30, 2023
4943f03
refactor: count by forEach + incrementing
gadenbuie Nov 30, 2023
4a8ca4b
`yarn build` (GitHub Actions)
gadenbuie Nov 30, 2023
75b50c6
thanks, vscode
gadenbuie Nov 30, 2023
6883344
docs: rewrite checkValidity() jsdoc to capture current state of things
gadenbuie Nov 30, 2023
5be1e65
chore: yarn build
gadenbuie Nov 30, 2023
a6b7c11
docs: slight rewording
gadenbuie Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading