feat: Improve notification styles #3913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
approved these changes
Oct 20, 2023
|
@gadenbuie just as a heads up, I decided to merge the news bullets for #3882 and #3914 since they're pretty related from an end-user perspective |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with (but doesn't require) rstudio/bslib#754
Brings a few minor adjustments to the notification styles:
Increase the touch area of the notification close button to a
2remsquare and use a pointer cursor.Allow the notifications to be slightly wider at 300px
Adjust padding to create a right-aligned gutter for the notification close button.
Give notification messages just a little bit more margin for breathing room.