-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Journal of Educational Data Mining #251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jooyoungseo !
For this one too can you verified your PR following the PR template ?
https://github.com/rstudio/rticles/blob/master/.github/PULL_REQUEST_TEMPLATE.md
I don't think there is much missing. Only a new test maybe for this format.
I'll deal with all the conflicts afterward unless you are used to do that - If not don't worry.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JooYoung Seo seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
[skip ci]
[skip ci]
[skip ci]
[skip ci]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was long overdue. I made the necessary change for this one.
I believe this is working as expected now.
Perfect. Thanks! |
Changes
jedm_article()
function inarticle.R
.README.md
;DESCRIPTION
; andNEWS.md
.Building
Rd2roxygen::rab()
function to buildrticles
package after change has been made.Testing
I have confirmed that
rticles::jedm_article()
output format works.Signed-Form