Support webtex for Github documents format #2301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #1886 and #2003
This adds a
math_method
argument togithub_document()
so that equation can be rendered as an image in the resulting md documentis rendered as
Some content
We ended up activating by default in github document where there is math. Like in Quarto.
We default to using PNG format with a DPI of 110 and using white background because otherwise (using svg for example) the equation would not be seen on dark mode in Github. We can't change the color font with the API.
However, Quarto defaults to SVG because this gives way cleaner output. Quarto documents how to change the background using PNG. Quarto doc about this: https://quarto.org/docs/output-formats/gfm.html#webtex-math
Should we default to the same ?
One thing is I am not sure about how we should consider CodeCog fair usage policy. https://editor.codecogs.com/docs/3-fair_usage.php, but I guess it is ok.