Explicit snapshot #1636
Merged
Explicit snapshot #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Aug 10, 2023
R/snapshot.R
Outdated
| @@ -91,6 +91,9 @@ the$auto_snapshot_hash <- TRUE | |||
| #' to the currently active package repositories, as retrieved by | |||
| #' `getOption("repos")`. | |||
| #' | |||
| #' @param dev Boolean; should development dependencies be captured | |||
There was a problem hiding this comment.
I think it also applies to the type all" Regardless, I'd suggest pointing people to the ?dependencies for more details.
There was a problem hiding this comment.
I added the link to the dependencies() help into the See Also section for more details about handling R package dependencies. Feel free to modify if you think this should be more prominent in shapshot().
Merge commit '250ea841644012eeda07f5226605037e148d938f' #Conflicts: # DESCRIPTION # NEWS.md
… to `dependencies()` in See Also section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we used to use
renv::snapshot(type = "explicit")to capture all dependencies stated in the DESCRIPTION file for package development. We put all packages we need for CICD to Suggests, as they are not required for a working package API.During CICD pipelines, we used
renv::restore()for installing all packages we need.After the recent update to v1.0.0 we basically ran into the same issue as described here:
#1019 (comment)
We don't like the idea of putting all CICD required packages into Imports. Instead, we propose to expose the option to record dev dependencies in the snapshot (and to consider them in checking the project status with
renv::status()).Please have a look. Thanks.