Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor R_LIBCURL_SSL_REVOKE_BEST_EFFORT #1624

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Honor R_LIBCURL_SSL_REVOKE_BEST_EFFORT #1624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4364ea
Honor R_LIBCURL_SSL_REVOKE_BEST_EFFORT
zeehio Aug 3, 2023
6ec5646
Update NEWS.md
zeehio Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@

* Use correct spelling of IRkernel package (#1528).

* Honor `R_LIBCURL_SSL_REVOKE_BEST_EFFORT` when using an external `curl.exe`
binary to download files (#1624)

# renv 1.0.0

Expand Down
5 changes: 5 additions & 0 deletions R/download.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,11 @@ renv_download_curl <- function(url, destfile, type, request, headers) {
args$push(extra)
}

# honor R_LIBCURL_SSL_REVOKE_BEST_EFFORT
# https://github.com/wch/r-source/commit/f1ec503e986593bced6720a5e9099df58a4162e7
if (Sys.getenv("R_LIBCURL_SSL_REVOKE_BEST_EFFORT") %in% c("T", "t", "TRUE", "true"))
args$push("--ssl-revoke-best-effort")

# add in any user configuration files
userconfig <- getOption(
"renv.curl.config",
Expand Down