Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add poppler-glib to poppler rule #179

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add poppler-glib to poppler rule #179

merged 2 commits into from
Sep 17, 2024

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Sep 14, 2024

To support packages like Rpoppler

@gaborcsardi
Copy link
Collaborator

We could also have another rule for this, to avoid unneeded stystem packages.

@pat-s
Copy link
Contributor Author

pat-s commented Sep 14, 2024

Sure, makes sense. Is this a fixed decision?

@glin
Copy link
Contributor

glin commented Sep 16, 2024

Yeah I think that would be ideal just because of how many automated processes are installing whatever comes back from the DB.

So currently only 2 CRAN packages seem to be using poppler, pdftools with SystemRequirements:

Poppler C++ API: libpoppler-cpp-dev (deb) or poppler-cpp-devel (rpm), and poppler-data (rpm/deb) package.

Rpoppler with SystemRequirements:

Poppler Glib interface headers and libraries (<http://poppler.freedesktop.org/>) [Debian/Ubuntu: libpoppler-glib-dev, Fedora: poppler-glib-devel]

We could copy-paste the existing poppler rule as a new poppler-glib rule, that just matches on "poppler glib" with the glib packages instead.

Then for the current one, changing it to match on "Poppler C\\+\\+" would be an option as I don't see any other CRAN packages that just have "poppler" in their system reqs, but I'm not sure if that would affect any other packages outside CRAN. I'd be fine with leaving the current rule as-is for now.

@pat-s pat-s marked this pull request as ready for review September 17, 2024 07:25
Copy link
Contributor

@glin glin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@glin glin merged commit e57f546 into rstudio:main Sep 17, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants