Skip to content

Commit

Permalink
Enable reportAssignmentType in pyright (#310)
Browse files Browse the repository at this point in the history
  • Loading branch information
nathanjmcdougall authored Dec 13, 2024
1 parent 368641f commit b613011
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
5 changes: 3 additions & 2 deletions pins/boards.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from typing import Mapping, Protocol, Sequence

from importlib_resources import files
from importlib_resources.abc import Traversable

from .cache import PinsCache
from .config import get_allow_rsc_short_name
Expand Down Expand Up @@ -994,8 +995,8 @@ class BoardRsConnect(BaseBoard):
# TODO: note that board is unused in this class (e.g. it's not in construct_path())

# TODO: should read template dynamically, not at class def'n time
html_assets_dir: Path = files("pins") / "rsconnect/html"
html_template: Path = files("pins") / "rsconnect/html/index.html"
html_assets_dir: Traversable = files("pins") / "rsconnect/html"
html_template: Traversable = files("pins") / "rsconnect/html/index.html"

# defaults work ----

Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ pythonPlatform = "Linux"

# Tracking compliance with these rules at https://github.com/rstudio/pins-python/issues/272
reportArgumentType = false
reportAssignmentType = false
reportAttributeAccessIssue = false
reportCallIssue = false
reportIncompatibleMethodOverride = false
Expand Down

0 comments on commit b613011

Please sign in to comment.