Skip to content

Commit

Permalink
refactor(fsspec): remove upper bound on fsspec
Browse files Browse the repository at this point in the history
We're using `pins` as a dependency in `ibis-framework` and ideally we
can remove the upper-pin on `fsspec` so that doesn't impact our users.
I think the usage of the moved `hash_name` function is the only breaking
change between the current upper pin and most recent release, so I've
added a small workaround to handle the change.

All of the local tests pass, I didn't yet set up sufficient credentials
to handle the various cloud tests.
  • Loading branch information
gforsyth committed Nov 8, 2023
1 parent d6c6778 commit a210de5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion pins/cache.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,18 @@
import shutil
import urllib.parse

from fsspec.implementations.cached import SimpleCacheFileSystem, hash_name
from fsspec.implementations.cached import SimpleCacheFileSystem
from fsspec import register_implementation
from pathlib import Path

from .config import get_cache_dir
from .utils import inform

try:
from fsspec.implementations.cached import hash_name
except ImportError:
hash_name = SimpleCacheFileSystem(target_protocol="").hash_name

_log = logging.getLogger(__name__)


Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ zipsafe = False

python_requires = >=3.7
install_requires =
fsspec>=0.8.0,<2023.9.0
fsspec>=0.8.0
pyyaml>=3.13
xxhash>=1.0.0
pandas>=0.23.0
Expand Down

0 comments on commit a210de5

Please sign in to comment.