opts.evaluate addresses #458 slow snapshot #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 31, 2018 12:12
|
Looks like this PR is duplicated from #512, is that intentional? |
|
Sorry, I see the motivation now in #458 (comment). |
kevinushey
reviewed
Oct 31, 2018
|
updated PR to use |
|
Thank you! The last thing I would ask -- do we already have a CLA on file? Would you mind filling out the form at https://www.rstudio.com/wp-content/uploads/2014/06/RStudioIndividualContributorAgreement.pdf and sending it to us (e-mail on the form)? |
|
Just sent it in- thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
fileDependencies.evaluateoption (default TRUE) to choose whether or not to recursively search for dependencies.