Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copies into cache need to first land in temporary location #333

Closed
aronatkins opened this issue Sep 13, 2016 · 1 comment
Closed

copies into cache need to first land in temporary location #333

aronatkins opened this issue Sep 13, 2016 · 1 comment

Comments

@aronatkins
Copy link
Contributor

moveInstalledPackageToCache copies a package from its initial install location to its final position in the packrat cache. This copy is performed to the actual destination. This means that we may leave a partial, but not obviously incomplete directory should that copy err for some reason or get interrupted.

if (all(dir_copy(packagePath, cachedPackagePath))) {

We should first copy to a temporary location (inside the same directory) and then perform a rename operation. Using the same parent directory ensures that we are on the same mounted device and the rename ensures that we will not accidentally see the package as already installed.

@kevinushey
Copy link
Contributor

Should be resolved now; thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants