Skip to content

Enhance automatic column alignment #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 8, 2022
Merged

Conversation

rich-iannone
Copy link
Member

With automatic column alignment (set to "auto" by default in the gt() function), columns (and their column labels) will be set on the basis of the content in the columns. The aim of this PR is to refine that a bit by changing the alignments of dates and time (to "right" alignment) but, also, making predominantly number-based strings align to the right. This ensures that string-based dates/times/datetimes receive a better appearance before formatting (so even if formatting isn't necessary, it'll still look formatted in terms of alignment).

@rich-iannone rich-iannone changed the title Tabular nums enhance Enhance automatic column alignment Aug 7, 2022
@rich-iannone rich-iannone requested a review from cscheid August 7, 2022 03:37
Copy link
Member

@cscheid cscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rich-iannone rich-iannone merged commit cb550b6 into master Aug 8, 2022
@rich-iannone rich-iannone deleted the tabular-nums-enhance branch August 8, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants