Skip to content

[Accessibility] Closing #679: Use <td> instead of <th> for title and subtitle #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

jooyoungseo
Copy link
Collaborator

This PR addresses #679: now screen readers don't get confused when using title and subtitle element.

Reprex

library(gt)

# Create gt table with title and subtitle
airquality[1:10, ] %>%
  gt::gt() %>%
  gt::tab_header(
    title = "Title",
    subtitle = "Subtitle"
  )

Results

title and subtitle now get treated as <td>. This is good for screen reader a11y.

@rich-iannone, I still need your help to verify whether there are any CSS tweaks that we need to consider. I don't want to introduce any visual breaks.

@jooyoungseo jooyoungseo requested a review from rich-iannone July 1, 2022 19:54
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants