Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve footnote marks #876

Merged
merged 10 commits into from
Feb 8, 2022
Merged

Improve footnote marks #876

merged 10 commits into from
Feb 8, 2022

Conversation

rich-iannone
Copy link
Member

This improves the appearance of footnote marks for HTML output.

Fixes: #511

@rich-iannone rich-iannone requested a review from jcheng5 February 4, 2022 05:38
@jcheng5
Copy link
Member

jcheng5 commented Feb 4, 2022 •
edited
Loading

Instead of not having gt_footnote_mark on *, let's instead add an additional class gt_asterisk if it's an asterisk. This lets people continue to use gt_footnote_mark to select/style footnote marks.

@rich-iannone
Copy link
Member Author

Instead of not having gt_footnote_mark on *, let's instead add an additional class gt_asterisk if it's an asterisk. This lets people continue to use gt_footnote_mark to select/style footnote marks.

Now done! Thanks for the input on this.

jcheng5
jcheng5 reviewed Feb 8, 2022
View reviewed changes
R/utils_render_html.R Outdated Show resolved Hide resolved
@rich-iannone rich-iannone merged commit 3e0a1ac into master Feb 8, 2022
@rich-iannone rich-iannone deleted the improve-footnote-marks branch February 8, 2022 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 jcheng5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

opt_footnote_marks symbols size is too small
2 participants
@rich-iannone @jcheng5