Fix resolution of column labels when applying footnotes/styles #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Renaming of API functions; documentation pass (#441)
jcheng5
approved these changes
Dec 19, 2019
rich-iannone
added a commit
that referenced
this pull request
Dec 19, 2019
* master: Fix resolution of column labels when applying footnotes/styles (#440)
rich-iannone
added a commit
that referenced
this pull request
Feb 5, 2020
* master: Remove use of emo package from example script (#469) Modify default CSS option for column `font-weight` (#468) Modify regex patterns to be less greedy Revise sentence in .Rmd file Revert changes to `as.tags` and add docs Add HTML dependency to the table Wrap HTML string in `HTML()` Place style block in <head> Fix for footnote glyphs not appearing with row labels (#447) Add test with `fmt_number()` and suffixing Fix #397: error with suffixing=TRUE with abs(x) < 1 Perform input validation and check for types when formatting (#450) Expand documentation such that all functions get at least one self-contained example (#451) Fix resolution of column labels when applying footnotes/styles (#440) Renaming of API functions; documentation pass (#441) Implement fix for UTF-8 (#436) Modify implemention of fix and add tests Fix error with `fmt_number()` on an NA-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the application of styles to column labels with the
cells_column_labels()location helper intab_style(). Internally, we now disregard hidden columns. Many testthat tests were added.Fixes: #438
Fixes: #439