Refactor footnotes tests + stores styles and footnotes in data frames. #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for refactoring the footnotes codebase. It seems to be one of the last places with |
|
Yes! I may get to this in a follow-up PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactors the tests for
tab_footnote()and also refactors footnote creation by taking advantage of.byinmutate()instead ofgroup_by()+mutate()+ungroup(). This should increase performance, but also doesn't reorder automatically. I haven't found issues related to this.Checklist
testthatunit tests totests/testthatfor any new functionality.