Skip to content

row_group_as_column = TRUE + 2 group variables #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 28, 2025

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Jul 17, 2024

Summary

I tried a lot of things, but I am now missing a bit of context.

This fixes only the following case:

mtcars |>
  group_by(vs, cyl) |> 
  gt(row_group_as_column = TRUE)

Related GitHub Issues and PRs

I ended up reverting the other commits because I am not getting it right.

for the original issue, it is a problem that the stub is not correctly initialized when row_group_as_column = TRUE + no row groups at the beginning.

and tab_row_group() doesn't behave well

Checklist

@olivroy olivroy marked this pull request as draft July 17, 2024 22:19
@olivroy olivroy changed the title Incorrect stub exploratiom Stub creation exploration Jul 17, 2024
@olivroy olivroy changed the title Stub creation exploration row_group_as_column = TRUE + 2 group variables Feb 28, 2025
@olivroy olivroy requested a review from rich-iannone February 28, 2025 13:37
@olivroy olivroy marked this pull request as ready for review February 28, 2025 13:37
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you!

@rich-iannone rich-iannone merged commit a982f55 into rstudio:master Feb 28, 2025
12 checks passed
@olivroy olivroy deleted the incorrect-stub branch March 5, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants