No error for data_color() + empty tidyselect for consistency with fmt_*()
#1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
data_color() + tidyselect for consistency
olivroy
changed the title
data_color() + tidyselect for consistencydata_color() + empty tidyselect for consistency with fmt_*()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After thinking about this a bit more, you are right that if we supply a tidyselect expression to
rowsorcolumnsthat resolves to nothing, we should just leave the data unchanged.This PR takes care of this and adds test to verify consistency between
data_color()andfmt_number().Related GitHub Issues and PRs
fixes #1665 and amends #1660
Checklist
testthatunit tests totests/testthatfor any new functionality.