Skip to content

actually fix NA row names in opt_interactive() #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Jul 8, 2024

I should have tested before comitting this #1758 (comment)...

If it is not too late, this version actually solves the problem I was trying to solve.

@olivroy olivroy requested a review from rich-iannone July 8, 2024 15:29
@olivroy olivroy changed the title R doesn't like empty (nor NAs) actually fix NA row names in opt_interactiv() Jul 8, 2024
@olivroy olivroy changed the title actually fix NA row names in opt_interactiv() actually fix NA row names in opt_interactive() Jul 8, 2024
@olivroy olivroy mentioned this pull request Jul 8, 2024
21 tasks
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rich-iannone rich-iannone merged commit d50ceaa into rstudio:v0.11.0-rc Jul 8, 2024
1 check passed
@olivroy olivroy deleted the patch-4 branch July 15, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants