-
Notifications
You must be signed in to change notification settings - Fork 214
Summary rows no row groups #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary rows no row groups #1752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the moment, I implemented the proposal of #1292, but I think that at this point, it is probably better to deprecate, since this has not worked for a while now.
input <- tryCatch(rlang::as_label(quo), error = NULL) | ||
if (identical(input, "everything()")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only way I found to figure out if the call was from grand_summary_rows()
or not.
groups <- | ||
resolve_groups( | ||
expr = {{ groups }}, | ||
vector = available_groups | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the resolver before has forced me to add the isFALSE()
condition in the resolver. The groups = FALSE
option is undocumented in summary_rows()
groups argument, but I wonder if I missed some other edge cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you might be fine here.
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: olivroy <52606734+olivroy@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! I'll merge once CI is completed. |
Fix #1292 #1420
It is now recommended to use
grand_summary_rows()
. The error message does a better job to point to the correct solution.