Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx the fix of Issue 1656 #1746

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Conversation

kbrevoort
Copy link
Collaborator

Summary

This PR makes a series of technical corrections to pull request #1716 to resolve issues that were pointed out by @nielsbock and @bzkrouse. It also contains a few other minor improvements to the code to make it more robust. There's no new functionality, just minor tweaks to make the functionality added to address #1656 more reliable.

Related GitHub Issues and PRs

Checklist

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rich-iannone
Copy link
Member

This is really great, thank you!!

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit 12ef56c into rstudio:master Jul 4, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants