Add tests for cols_units()
and fix edge case + improve error messages for cells_grand_summary()
#1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since it could detect the end of the string in
unit
, this would faildue to the fact that the gsub part is TRUE.
Let me know if you want me to buildignore the
cols_units()
tests.As always, this occured randomly to me. None of this is related to what I intended to do in the first place, but caught previous mistakes (made by me) and some unfound stuff!
Related GitHub Issues and PRs
Also improve some messages and add some basic checking of input.
Checklist
testthat
unit tests totests/testthat
for any new functionality.