Add ihtml.height
for interactive custom widget height
#1723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To mitigate #1544, specifying manually height could be useful.
Before, there was no way to prevent overflowing with
opt_interactive()
. Let me know if there is a better way to do this. I tried modifying theheight
value toNULL
, or"auto"
in thereactable::reactable()
call inrender_as_ihtml()
, but couldn't find a way to do this well. The only way I found was with manual override. Figure a way to find out the RStudio viewer's size. But after my research, I figured that giving the option to user exactly how to set their widget's height was a good way to go?I am not too familiar with setting options, and this will likely ignore static options set. I don't know which
tab_options()
are expected to have an effect in both interactive and non-interactive?Before:
This PR: