Skip to content

test as-word on CI #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2024
Merged

test as-word on CI #1718

merged 5 commits into from
Jun 19, 2024

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Jun 19, 2024

Summary

Update the test-coverage action with usethis::use_github_action("test-coverage"), so we will be able to see a more complete report. (This is our main CI testing feature, so it has to be informative)

I think we should test the test-as-word.R file on coverage. (already skipped on CRAN and added to .Rbuildignore
Additionally, this closes #1714 to use the convention of using check_suggests() in gt.

In DESCRIPTION, Config/Needs/coverage is used to specify packages that are installed on the test-coverage action only. Documented here https://remotes.r-lib.org/reference/install_url.html#arguments

Checklist

@olivroy olivroy marked this pull request as ready for review June 19, 2024 15:39
@rich-iannone rich-iannone self-requested a review June 19, 2024 17:12
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit 1ed4a2c into rstudio:master Jun 19, 2024
12 checks passed
@olivroy
Copy link
Collaborator Author

olivroy commented Jun 19, 2024

@rich-iannone. I think this new action requires action on your side to add a Codecov token to the repo's secret to continue uploading coverage reports.
r-lib/actions#834

@olivroy olivroy deleted the coverage-update branch June 19, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants