Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create check_column_valid() to validate column class if needed. #1715

Merged
merged 15 commits into from
Jun 19, 2024

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Jun 19, 2024

Summary

  • SImplify input checking (test for option before column class as it should be quicker)
  • Add some check_*() function usage
  • Add some call argument to validate_currency() and validate_locale() for precise user message location
  • Transform some help links into run links to be able to quickly visualize the info_*() reference table.

Not sure I understand the End support for gt_column() comment? I moved it around in some places, but not others

Checklist

@olivroy olivroy marked this pull request as ready for review June 19, 2024 12:33
R/format_data.R Outdated Show resolved Hide resolved
@rich-iannone
Copy link
Member

the End support for gt_column() comment?

This is just to mark the end of the statements that dealt with running a formatter with different parameter values. And, this is actually an earlier name for the from_column() function (so it's now a typo). This set of comments could either be entirely removed (i.e., served its purpose during earlier development) or corrected.

@olivroy
Copy link
Collaborator Author

olivroy commented Jun 19, 2024

Ok, once you are done reviewing the PR, I will address your comments, and delete this comment

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@olivroy
Copy link
Collaborator Author

olivroy commented Jun 19, 2024

Ended up leaving the comment (and correcting), as it helps to make the code base clear!

Pushed some minor changes as well too.

@rich-iannone
Copy link
Member

This is great, thanks again! Will merge now.

@rich-iannone rich-iannone merged commit 4992ab7 into rstudio:master Jun 19, 2024
12 checks passed
@olivroy olivroy deleted the cond-fmt branch June 19, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants