-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create check_column_valid()
to validate column class if needed.
#1715
Conversation
This is just to mark the end of the statements that dealt with running a formatter with different parameter values. And, this is actually an earlier name for the |
Ok, once you are done reviewing the PR, I will address your comments, and delete this comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Ended up leaving the comment (and correcting), as it helps to make the code base clear! Pushed some minor changes as well too. |
This is great, thanks again! Will merge now. |
Summary
check_*()
function usagecall
argument tovalidate_currency()
andvalidate_locale()
for precise user message locationhelp
links intorun
links to be able to quickly visualize theinfo_*()
reference table.Not sure I understand the End support for
gt_column()
comment? I moved it around in some places, but not othersChecklist
testthat
unit tests totests/testthat
for any new functionality.