clarify documentation for a nanoplot example #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Correct reference to previously-used `cols_hide()` in one of the nanoplot examples that currently uses `autohide = FALSE` 2. and give context (specify the relevant option) for statement about connecting line not being valuable here. I'm attempting my first nanoplot today so take this suggestion with a giant heaping of salt. But in reading through this example, I thought it could be clearer. Thank you for your incredible documentation — I think it is the 8th wonder of the world!!
|
Thanks so much for submitting this! Your changes here are great and so I'll merge this very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct reference to previously-used
cols_hide()in one of the nanoplot examples that currently usesautohide = FALSEand give context (specify the relevant option) for statement about connecting line not being valuable here.
I'm attempting my first nanoplot today so take this suggestion with a giant heaping of salt. But in reading through this example, I thought it could be clearer.
Thank you for your incredible documentation — I think it is the 8th wonder of the world!!
Summary
Thank you for contributing to gt! To make this process easier for everyone, please explain the context and purpose of your contribution. Also, list the changes made to the existing code or documentation.
Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.