Remove spec() from dataset generation scripts #1699
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1697
The next time datasets are built, they will remove the readr::spec() attribute. Other datasets don't have this issue.
This is very minor, but it is just that object comparisons will be a little bit easier if we drop these classes.
I didn't rebuild the data as this is minor and this will naturally occur next time you need to add a dataset.
Strategy found in readr 1.3.0 changelog https://readr.tidyverse.org/news/index.html#tibble-data-frame-subclass-1-3-0
Basically, this aims to solve this.
WIth the help of this PR, eventually when the datasets are redone,
Note that gtcars2 still has tbl_df class ("tbl_df" "tbl" "data.frame")