Standardize vec_*()
error messages with check_vector_valid()
#1662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This standardizes error messages for
vec_*()
and is inspired by the tidyverse style guide.It gets rid of two internal functions
stop_if_not_vector()
andvector_class_is_valid()
and consolidates them into one:check_vector_valid()
, which does a mix of both.x
is not vector isvalid_classes
is not presentx
is not vector orx
doesn't inheritvalid_classes
Overview of
check_vector_valid()
Created on 2024-05-13 with reprex v2.1.0
Checklist
testthat
unit tests totests/testthat
for any new functionality.