handle correctly rtf saving with cols_label + summary_rows / grand_summary_rows #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
|
@olivroy thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simple fix for gtsave() for .rtf with
cols_label().Extended the fix to
grand_summary_rows()as well!Note: The other saving tests don't work well on Windows on my machine, maybe double check if they run as expected for you locally? I also have not tested this widely.
Tested that the fix works for both
summary_rows()and / orgrand_summary_rows().Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.Screenshot
rtf
html