Skip to content

Update several images in the documentation #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Conversation

rich-iannone
Copy link
Member

This updates a few images used in the documentation, mostly related to typesetting changes in the table footer.

Fixes: #1554

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new table looks a bit weird, the numbers should all be aligned? Is this intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify which image doesn't look right to you?

Copy link
Collaborator

@olivroy olivroy Jan 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the 624 should be aligned with 2016? image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for showing this (because I thought you meant something else). Yeah, I don't like it and it needs a fix. This problem can happen everywhere there's a superscript so I need to find a pretty universal solution. Could you open a separate issue for this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems pretty complicated. Thanks for all this great work. It is overall very awesome.

@rich-iannone rich-iannone merged commit dc34298 into master Jan 25, 2024
@rich-iannone rich-iannone deleted the docs-images-update branch January 25, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footnote symbol in cell appears before value instead of after
2 participants