Issue 1465 #1495
Merged
Issue 1465 #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the use of percentage symbols to express column widths, which cause an error when compiling Latex, with column widths that are expressed as a share of `\linewidth` or the user-supplied `table_width`.
Anchors LaTeX longtable to match a width set by the user. Table width is achieved by changing the space between columns to produce a table that matches the specified width.
kbrevoort
added a commit
to kbrevoort/gt
that referenced
this pull request
Nov 20, 2023
|
Thank you so much for submitting this PR! I'll review this PR pretty soon. |
|
@kbrevoort Before merging, could you fill out the CLA? |
|
@rich-iannone, can you point me to where I can find the CLA? I haven't been able to figure out how to access it. |
|
@kbrevoort @rich-iannone - I'm just bumping this because it seems the only thing holding it up is accepting the contributor license agreement(?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses two previously-reported bugs associated with outputting tables to LaTeX.
cols_width()Produces an Error When Usingpct()inside It in LaTeX/PDF Output #1465: Fixes an issue where table columns specified with thepctfunction cause LaTeX compilation errors. The error is caused by the fact that specifyingcols_width(everything() ~ pct(20))specifies the column width in LaTeX as "20%". Since % is the comment symbol in LaTeX, this produces a compilation error. The code has been changed so that the column width in LaTeX will be output as "0.2\linewidth" if the table width is unspecified (in which case each column will take up 20% of the available width) or 0.2 times the specified table width.tab_options(table.width = pct(100))) or as specific units (i.e.,tab_options(table.width = '400px')). Table widths are established using the specified LaTeX lengths \LTleft and \LTright. Extra space to fill out the table width, if necessary, is added in between the columns by setting `\extracolsep to \fill. (The code also creates two temporary length measures in LaTex, \holdLTleft and \holdLTright which record the existing length values of \LTleft and \LTright before setting them to the user-specified lengths for the table. After the longtable environment is ended, the preexisting values of \LTleft and \LTright are restored.Related GitHub Issues and PRs
cols_width()Produces an Error When Usingpct()inside It in LaTeX/PDF Output #1465Checklist
testthatunit tests totests/testthatfor any new functionality.