Make gtsave return file path invisibly. #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! Agree it’s much better to return the image path rather than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Have gtsave follow more closely
ggsave()by returning the file path instead ofTRUE.This is a naive solution. I guess the code could be cleaned up a little bit for
gtsave()since the related htmltools issue seems to have been solved. May no longer require this fs code?Some tests seem to be a little redundant too? I could take another (more thorough) shot at the
gtsave()code and tests if you think this is worth pursuing.Checklist
testthatunit tests totests/testthatfor any new functionality.