Add custom attribute support to fmt_url (#1428)
#1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename `add_href_attr` helper to more accurate `add_anchor_attr`
Also fixes inline markup in cli_abort message from obj_simple_type (wrong) to obj_type_friendly (right)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds the following HTML attributes for the anchor HTML element to the
fmt_url()function:The primary goal for this addition is to allow the use of values for target other than "_self" but it seemed appropriate to add support for the other attributes at the same time.
Additional documentation could be added explaining the validation for each of the attributes (
hreflangandtypeare not validated andpingis only validated to ensure it is a character vector) and add examples for use of the new parameters. One additional (currently not implemented) feature could be to add a style parameter that allows users to ignore theshow_underlineandas_buttonattributes and pass custom CSS for URL formatting.Related GitHub Issues and PRs
fmt_url()#1428Checklist
Unsure if this constitutes a major change so I have not yet updated NEWS.md.
testthatunit tests totests/testthatfor any new functionality.