Skip to content

Add features/updates to cols_nanoplot() #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Sep 29, 2023
Merged

Conversation

rich-iannone
Copy link
Member

This PR adds the bar plot plot_type to cols_nanoplot(). Also, a y-axis guide is added and active by default (can be disabled with nanoplot_options()). Some options in cols_nanoplot() have been moved to nanoplot_options().

* master: (25 commits)
  Update z_utils_render_footnotes.R
  Update z_utils_render_footnotes.R
  Reverting for now to avoid potential conflict
  Update utils_plots.R
  Update utils_formatters.R
  Update dt_cols_merge.R
  Last check length before match
  Require min testthat + check length before match.
  Tweaks to tests.
  Final conversions to expect_no_error
  Usage of new testthat functions
  Fix unintended WS changes.
  Update test-data_color.R
  Typos.
  Other tests tweaks.
  Replace `expect_error(regexp = NA, ` by `expect_no_error(`
  Simplifications of tests
  Misc minor messages adjustments.
  Remaining package install changes
  More cli inline markup.
  ...
@rich-iannone rich-iannone merged commit 8e9443f into master Sep 29, 2023
@rich-iannone rich-iannone deleted the cols-nanoplot-revise branch September 29, 2023 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant