Skip to content

Pkgdown #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 4, 2023
Merged

Pkgdown #1444

merged 9 commits into from
Oct 4, 2023

Conversation

olivroy
Copy link
Collaborator

@olivroy olivroy commented Sep 25, 2023

Summary

Improve the pkgdown site by adding links to blog posts, and renaming the intro vignette to gt.Rmd to automatically generate a Get Started vignette. It also removes duplication in the Articles dropdown. I also added a redirect link.

image

Small question: would it be possible to remove the bold font from all the text. It is useful in some place, but when it is everywhere, it is difficult to read. This was requested here #1419 (comment). I think the user feels the same way as me. The bold everywhere feels a bit overwhelming...

I tried playing around but could not figure it out.

This will rename Intro -> Get Started

Since I did not want to add all seven blog posts for gt 0.9.0, I included only a permalink of the searched text (similar to dplyr 1.1.0)

Checklist

@rich-iannone
Copy link
Member

I've changed the fonts for the pkgdown site in e11b220. I didn't realize it looked that bad until the user's comment in #1419 (comment) (where it's really bold on Windows systems). It looks much more reasonable now and I've updated this PR to have the latest on master.

@olivroy
Copy link
Collaborator Author

olivroy commented Oct 1, 2023

The font looks better now!! thanks

@rich-iannone rich-iannone self-requested a review October 4, 2023 01:12
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rich-iannone rich-iannone merged commit a72de96 into rstudio:master Oct 4, 2023
@olivroy olivroy deleted the pkgdown branch November 1, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants