Add support for locales to cols_merge_range()
#1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Range patterns across locales are different (e.g., can involve use of a single hyphen, en dash, em dash, tilde, etc.) and it does make sense to follow the convention of a locale. This can be specified in the initial
gt()call, within a function (overriding the previous method, if it was used), and the effect of a locale setting can also be overridden by providing theseparatortext (we avoid the use of a"{1}<sep>{2}"pattern construction for sake of simplicity here.This PR adds
localetocols_merge_range()and setsseptoNULL. If both are not used then the separator of the"en"locale or whichever locale set ingt()determines the separator. This doesn't break backwards compatibility. All existing code should work the same with no warnings given whatsoever.Fixes: #158