Word footnote special characters

.gitignore

@@ -44,3 +44,4 @@ test.rtf
 docs
 *.html
 *.qmd
+/*.docx

NEWS.md

@@ -2,6 +2,8 @@
 
 * Update to `col_hide(columns=)` and `cols_unhide(columns=)` arguments. The functions no longer return an error if no columns are selected. (#1342)
 
+* Update word processing to htmlEscape all characters before it goes into xml_t. This means now footnotes are escaped too. (#1303)
+
 # gt 0.9.0
 
 ## New features

R/utils.R

@@ -687,7 +687,7 @@ process_text <- function(text, context = "html") {
 
       text <- markdown_to_xml(text)
     }else{
-      text <- htmltools::htmlEscape(as.character(text))
+      text <- as.character(text)
     }
 
     return(text)

R/utils_render_xml.R

@@ -2560,7 +2560,7 @@ parse_to_xml <- function(x, ...) {
         ),
         xml_r(
           xml_rPr(),
-          xml_t(x)
+          xml_t(enc2utf8(htmltools::htmlEscape(x)))
         )
       )
 

tests/testthat/test-as_word.R

@@ -242,6 +242,21 @@ test_that("word ooxml escapes special characters in gt object", {
 
 })
 
+test_that("word ooxml escapes special characters in gt object footer", {
+
+  # Create a one-row table for these tests
+  exibble_min <- exibble[1, ]
+
+  ## basic table with invalid footnote
+  exibble_min %>%
+    gt() %>%
+    tab_footnote(footnote = "p < .05, ><&\n\r\"'") %>%
+    as_word() %>%
+    expect_snapshot()
+
+})
+
+
 test_that("tables can be added to a word doc", {
 
   check_suggests_xml()