-
Notifications
You must be signed in to change notification settings - Fork 214
initial workings for adding images to word outputs #1273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial workings for adding images to word outputs #1273
Conversation
Merge branch 'master' into word_handling_imgs # Conflicts: # R/utils.R # R/utils_render_xml.R
@rich-iannone - curious to get your feedback. also, I wanted to comment that fmt_image only has height as an option, not width. That works for html, since it will just scale the image, but word requires both height and width. the code as-is works with square images added, but it will square out any other images. |
@thebioengineer Sorry for the delay in responding here. I will try this out. About having just |
We can definitely do that, but I'd need to sort out how to do that without Magick or other packages like that, since I was trying to not add a dependency |
…ts (still as suggests)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Thank you for contributing to gt! To make this process easier for everyone, please explain the context and purpose of your contribution. Also, list the changes made to the existing code or documentation.
Related GitHub Issues and PRs
Checklist
testthat
unit tests totests/testthat
for any new functionality.TODO: